T-SQL Syntax Error (conversion

Hi,

New to the forum here, it seems like this is a good SQL Server resource...

I'm still somewhat in the learning phases of T-SQL coding, and so far what I've learned has been pretty beneficial...a problem i'm having at the moment though, is with some conversion. I created a stored procedure that basically takes all the records from one table to another. I'll paste the code onto here and show you what's flagging on me (comment about the error within code). It probably seems a bit convoluted, but the UserProfileValue table is something that I TOTALLY wish Microsoft had second-guessed (it's from SharePoint Portal Server 2003)


SET QUOTED_IDENTIFIER ON
GO
SET ANSI_NULLS ON
GO


ALTER procedure profile_ImportUserProfileData

as

declare profile_curs cursor for
select UserProfileValue.RecordID, UserProfileValue.PropertyID, UserProfileValue.PropertyVal, PropertyList.PropertyName, PropertyList.DataType
from PropertyList
inner join UserProfileValue
on PropertyList.PropertyID = UserProfileValue.PropertyID
order by UserProfileValue.RecordId,
UserProfileValue.PropertyId

declare @RecordId int, @PropertyId int, @OldRecordId int
declare @PropertyVal sql_variant
declare @PropertyName nvarchar(20), @DataType nvarchar(20)
declare @table nvarchar(25)

set @table = 'UserProfileReportTable'

open profile_curs
fetch next from profile_curs into @RecordId, @PropertyId, @PropertyVal, @PropertyName, @DataType

if (@@fetch_status = -1)
begin
print 'End of table'
close profile_curs
deallocate profile_curs
return
end

while (@@fetch_status = 0)
begin
SET IDENTITY_INSERT UserProfileReportTable ON
insert UserProfileReportTable(RecordId)
values(@RecordId)
SET IDENTITY_INSERT UserProfileReportTable OFF

set @OldRecordId = @RecordId

fetch next from profile_curs into @RecordId, @PropertyId, @PropertyVal, @PropertyName, @DataType

if @DataType like 'nvarchar'
set @DataType = @DataType + '(20)'

while (@RecordId = @OldRecordId)
begin
declare @sql nvarchar(1000)
set @sql = 'update ' + @table
-- this next line is the one that's crapping out, saying "Incorrect syntax near @DataType"
set @sql = @sql + ' set ' + @PropertyName + ' = ' + convert(@DataType, @PropertyVal)
set @sql = @sql + ' where RecordId = ' + @RecordId
execute sp_executesql @sql
fetch next from profile_curs into @RecordId, @PropertyId, @PropertyVal, @PropertyName, @DataType
end
end

close profile_curs
deallocate profile_curs


GO
SET QUOTED_IDENTIFIER OFF
GO
SET ANSI_NULLS ON
GO


I also tried cast(@PropertyVal as @DataType) but got the same results. I know it probably isn't the best idea to use a cursor, considering there are 3000+ records in UserProfileValue, but more than likely this procedure will only be run once, and I couldn't think of any better way to do it. Any help would be appreciated.

Thanks!