Hello Everyone, I am still learning Sql and need some help with a query. On the master table, I have an audit log. I have a trigger set up to run after an update. I only want to perform an update if the value is not true or one record updated will result on 1800 records in you audit log. I tried to disable and enable the trigger from within the trigger unsuccessfully. So now I am trying an If statement, in a trigger Maybe this is where you can help ?
I get the following error
Msg 512, Level 16, State 1, Line 1
Subquery returned more than 1 value. This is not permitted when the subquery follows =, !=, <, <= , >, >= or when the subquery is used as an expression.
Extract from Trigger.
If (Select Discprency from Master_Table
where ((Pro1 <> Pro2 and Pro1 <> Pro3) or
(Pro2 <> Pro1 and Pro2 <> Pro3) or
(Pro3 <> Pro1 and Pro3 <> Pro2) or
(Pro1 = Pro2 and Pro1 <> Pro3 and Pro2 <> Pro3) or
(Pro1 = Pro3 and Pro1 <> Pro2 and Pro2 <> Pro3) or
(Pro2 = Pro3 and Pro1 <> Pro2 and Pro3 <> Pro1))) = 0
Begin
Update Master_Table
set Discprency = '1'
where Discprency = 0
End
Else
Begin
Update Master_Table
set Discprency = '0'
where Discprency = 1
End
Just me looking for some advice again on my complicated logon / registration process with DNN.
I ask my users to enter their league membership number as a password - this is then checked in a standalone table of data imported from FoxPro to test whether the membership no. i.e. password is current or not .... this all works fine. I do have a bit of a problem with the initial registration on the site however ...
All membership numbers acutally consist of a league division followed by the membership number so e.g. the member number 6789767 actually consists of two pieces of information - the first character is the league division and 789767 is actually the foxpro member number. So what I do is strip the first character away on sign in and registration when I am testing to see whether the user is a current league member e.g. ...
Dim MemberID As String = objUser.IsMember(Server.HtmlEncode(Mid(txtpassword.Text,2,10)))
This allows me to grab the real membership number out of the password and also helps to stop password guessing as no one will realise the first character is being stripped away. Fine except with the AddUser code in register.ascx.vb .... I don't know why but when I try to strip away the first character in a similar way in this line
well it does the right thing and only adds the password minus the first character to the users table however when the user is pointed back at desktopdefault the users name is not displayed, the additional tabs available to registered users do not appear however the logoff link is active ... strange why this should be so but I can't work out what the problem is. So I was thinking that another way to approach this would be a trigger on the users table so that when a new record is inserted the trigger runs and strips the first character off the password before the password is committed to the table.
Can anyone show me a simple trigger that will do this / comment on why the problem with AddUser occurs .... not au fait with triggers but a trigger could make me happy in this instance I think.
I am trying to create a very minimal auditing system for a series ofdatabases.I am in the process of writing Update triggers for 5 Tablse. I willwrite a trigger for each table-the trigger's function will be toINSERT a row into my MasterChanges table everytime ANY data is changedin each of the 5 tables.I have set up MasterChanges to capture the following:what Table the change was made inwhat Field the change was made inwhat the Field was changed towhen this change occured.I have used the Columns_Update() function to enable the trigger tosurvey all 22 fields in the first table (my first attempt at this). Ican hardcode in the table's name, as there will be a separate triggerfor each table.The problem is how to identify the NAME of the COLUMN that was updatedand have the trigger write that NAME into MasterChanges, as well asthe new value of that column.My first thought is a very unacceptable hardcoding of multiple IFSTATEMENTS for each of the 22 fields.ie:IF(colA) then...elseif(colB) then...elseif(colC) then...etc.There must be a better way to do itI assume this would be done using Columns_Update() in some way, butcannot figure it out.Can anyone help?Thanks,Trevor Fairchild
How am I doing so far? I am trying to Insert the user_id if it does not allready exist in the table. But it does not like the value I am giving it in the INSERT statement. What can I do? ALTER PROCEDURE dbo.ap_Update_Usr_Type_Data
-- define parameters --@passUserId int
AS
--Set @passUserId = UserId
SELECT [user_id] As UserId FROM CC_host.dbo.usr_table As t1 Where(email LIKE N'%@%' And email LIKE N'%usa.com') Order By UserId
If Not Exists (Select [user_id] As UserId2 From Usr_Type_Data WHERE UserId2 = UserId)
INSERT INTO Usr_Type_Data (user_id, CustomerTypeId) VALUES(t1.UserId, 7)
GO The error I am getting in Query Analyzer (SQL SERVER 2000) is: The name 'UserId' is not permitted in this context. Only constants, expressions, or variables allowed here. Column names are not permitted.
If you are please let me know what software you are using. We currently are using Legato to back up our SQL Servers and it has proven to be a real nightmare. Backing up to disk is not a solution for me since we have too many servers(16) and medium to large Dbs. I would love any ones input into your current backup solution. Are you happy with backup time and restore time and is it reliable?
I just wanted to wish everyone a Happy New Years and I wanted to thank all submitters to this forum for breaking up my code monkey workday and cutting into my productivity and I have found many of these discussions helpful in my preperation for my long procrastinated MCDBA exams.
I'm new to this whole SQL Server 2005 thing as well as database design and I've read up on various ways I can integrate business constraints into my database. I'm not sure which way applies to me, but I could use a helping hand in the right direction.
A quick explanation of the various tables I'm dealing with: WBS - the Work Breakdown Structure, for example: A - Widget 1, AA - Widget 1 Subsystem 1, and etc. Impacts - the Risk or Opportunity impacts for the weights of a part/assembly. (See Assemblies have Impacts below) Allocations - the review of the product in question, say Widget 1, in terms of various weight totals, including all parts. Example - September allocation, Initial Demo allocation, etc. Mostly used for weight history and trending Parts - There are hundreds of Parts which will eventually lead to thousands. Each part has a WBS element. [Seems redundant, but parts are managed in-house, and WBS elements are cross-company and issued by the Government] Parts have Allocations - For weight history and trending (see Allocations). Example, Nut 17 can have a September 1st allocation, a September 5th allocation, etc. Assemblies - Parts are assemblies by themselves and can belong to multiple assemblies. Now, there can be multiple parts on a product, say, an unmanned ground vehicle (UGV), and so those parts can belong to a higher "assembly" [For example, there can be 3 Nut 17's (lower assembly) on Widget 1 Subsystem 2 (higher assembly) and 4 more on Widget 1 Subsystem 5, etc.]. What I'm concerned about is ensuring that the weight roll-ups are accurate for all of the assemblies. Assemblies have Impacts - There is a risk and opportunity impact setup modeled into this design to allow for a risk or opportunity to be marked on a per-assembly level. That's all this table represents.
A part is allocated a weight and then assigned to an assembly. The Assemblies table holds this hierarchical information - the lower assembly and the higher one, both of which are Parts entries in the [Parts have Allocations] table.
Therefore, to ensure proper weight roll ups in the [Parts have Allocations] table on a per part-basis, I would like to check for any inserts, updates, deletes on both the [Parts have Allocations] table as well as the [Assemblies] table and then re-calculate the weight roll up for every assembly. Now, I'm not sure if this is a huge performance hog, but I do need to keep all the information as up-to-date and as accurate as possible. As such, I'm not sure which method is even correct, although it seems an AFTER DML trigger is in order (from what I've gathered thus far). Keep in mind, this trigger needs to go through and check every WBS or Part and then go through and check all of it's associated assemblies and then ensure the weights are correct by re-summing the weights listed.
If you need the design or create script (table layout), please let me know.
Are there any limitations or gotchas to updating the same table whichfired a trigger from within the trigger?Some example code below. Hmmm.... This example seems to be workingfine so it must be something with my specific schema/code. We'reworking on running a SQL trace but if anybody has any input, fireaway.Thanks!create table x(Id int,Account varchar(25),Info int)GOinsert into x values ( 1, 'Smith', 15);insert into x values ( 2, 'SmithX', 25);/* Update trigger tu_x for table x */create trigger tu_xon xfor updateasbegindeclare @TriggerRowCount intset @TriggerRowCount = @@ROWCOUNTif ( @TriggerRowCount = 0 )returnif ( @TriggerRowCount > 1 )beginraiserror( 'tu_x: @@ROWCOUNT[%d] Trigger does not handle @@ROWCOUNT[color=blue]> 1 !', 17, 127, @TriggerRowCount) with seterror, nowait[/color]returnendupdate xsetAccount = left( i.Account, 24) + 'X',Info = i.Infofrom deleted, inserted iwhere x.Account = left( deleted.Account, 24) + 'X'endupdate x set Account = 'Blair', Info = 999 where Account = 'Smith'
This Audit Trigger is Generic (i.e. non-"Table Specific") attach it to any tabel and it should work. Be sure and create the 'Audit' table first though.
The following code write audit entries to a Table called 'Audit' with columns 'ActionType' //varchar 'TableName' //varchar 'PK' //varchar 'FieldName' //varchar 'OldValue' //varchar 'NewValue' //varchar 'ChangeDateTime' //datetime 'ChangeBy' //varchar
using System; using System.Data; using System.Data.SqlClient; using Microsoft.SqlServer.Server;
public partial class Triggers { //A Generic Trigger for Insert, Update and Delete Actions on any Table [Microsoft.SqlServer.Server.SqlTrigger(Name = "AuditTrigger", Event = "FOR INSERT, UPDATE, DELETE")]
public static void AuditTrigger() { SqlTriggerContext tcontext = SqlContext.TriggerContext; //Trigger Context string TName; //Where we store the Altered Table's Name string User; //Where we will store the Database Username DataRow iRow; //DataRow to hold the inserted values DataRow dRow; //DataRow to how the deleted/overwritten values DataRow aRow; //Audit DataRow to build our Audit entry with string PKString; //Will temporarily store the Primary Key Column Names and Values here using (SqlConnection conn = new SqlConnection("context connection=true"))//Our Connection { conn.Open();//Open the Connection //Build the AuditAdapter and Mathcing Table SqlDataAdapter AuditAdapter = new SqlDataAdapter("SELECT * FROM Audit WHERE 1=0", conn); DataTable AuditTable = new DataTable(); AuditAdapter.FillSchema(AuditTable, SchemaType.Source); SqlCommandBuilder AuditCommandBuilder = new SqlCommandBuilder(AuditAdapter);//Populates the Insert command for us //Get the inserted values SqlDataAdapter Loader = new SqlDataAdapter("SELECT * from INSERTED", conn); DataTable inserted = new DataTable(); Loader.Fill(inserted); //Get the deleted and/or overwritten values Loader.SelectCommand.CommandText = "SELECT * from DELETED"; DataTable deleted = new DataTable(); Loader.Fill(deleted); //Retrieve the Name of the Table that currently has a lock from the executing command(i.e. the one that caused this trigger to fire) SqlCommand cmd = new SqlCommand("SELECT object_name(resource_associated_entity_id) FROM ys.dm_tran_locks WHERE request_session_id = @@spid and resource_type = 'OBJECT'", conn); TName = cmd.ExecuteScalar().ToString(); //Retrieve the UserName of the current Database User SqlCommand curUserCommand = new SqlCommand("SELECT system_user", conn); User = curUserCommand.ExecuteScalar().ToString(); //Adapted the following command from a T-SQL audit trigger by Nigel Rivett //http://www.nigelrivett.net/AuditTrailTrigger.html SqlDataAdapter PKTableAdapter = new SqlDataAdapter(@"SELECT c.COLUMN_NAME from INFORMATION_SCHEMA.TABLE_CONSTRAINTS pk , INFORMATION_SCHEMA.KEY_COLUMN_USAGE c where pk.TABLE_NAME = '" + TName + @"' and CONSTRAINT_TYPE = 'PRIMARY KEY' and c.TABLE_NAME = pk.TABLE_NAME and c.CONSTRAINT_NAME = pk.CONSTRAINT_NAME", conn); DataTable PKTable = new DataTable(); PKTableAdapter.Fill(PKTable);
switch (tcontext.TriggerAction)//Switch on the Action occuring on the Table { case TriggerAction.Update: iRow = inserted.Rows[0];//Get the inserted values in row form dRow = deleted.Rows[0];//Get the overwritten values in row form PKString = PKStringBuilder(PKTable, iRow);//the the Primary Keys and There values as a string foreach (DataColumn column in inserted.Columns)//Walk through all possible Table Columns { if (!iRow[column.Ordinal].Equals(dRow[column.Ordinal]))//If value changed { //Build an Audit Entry aRow = AuditTable.NewRow(); aRow["ActionType"] = "U";//U for Update aRow["TableName"] = TName; aRow["PK"] = PKString; aRow["FieldName"] = column.ColumnName; aRow["OldValue"] = dRow[column.Ordinal].ToString(); aRow["NewValue"] = iRow[column.Ordinal].ToString(); aRow["ChangeDateTime"] = DateTime.Now.ToString(); aRow["ChangedBy"] = User; AuditTable.Rows.InsertAt(aRow, 0);//Insert the entry } } break; case TriggerAction.Insert: iRow = inserted.Rows[0]; PKString = PKStringBuilder(PKTable, iRow); foreach (DataColumn column in inserted.Columns) { //Build an Audit Entry aRow = AuditTable.NewRow(); aRow["ActionType"] = "I";//I for Insert aRow["TableName"] = TName; aRow["PK"] = PKString; aRow["FieldName"] = column.ColumnName; aRow["OldValue"] = null; aRow["NewValue"] = iRow[column.Ordinal].ToString(); aRow["ChangeDateTime"] = DateTime.Now.ToString(); aRow["ChangedBy"] = User; AuditTable.Rows.InsertAt(aRow, 0);//Insert the Entry } break; case TriggerAction.Delete: dRow = deleted.Rows[0]; PKString = PKStringBuilder(PKTable, dRow); foreach (DataColumn column in inserted.Columns) { //Build and Audit Entry aRow = AuditTable.NewRow(); aRow["ActionType"] = "D";//D for Delete aRow["TableName"] = TName; aRow["PK"] = PKString; aRow["FieldName"] = column.ColumnName; aRow["OldValue"] = dRow[column.Ordinal].ToString(); aRow["NewValue"] = null; aRow["ChangeDateTime"] = DateTime.Now.ToString(); aRow["ChangedBy"] = User; AuditTable.Rows.InsertAt(aRow, 0);//Insert the Entry } break; default: //Do Nothing break; } AuditAdapter.Update(AuditTable);//Write all Audit Entries back to AuditTable conn.Close(); //Close the Connection } }
//Helper function that takes a Table of the Primary Key Column Names and the modified rows Values //and builds a string of the form "<PKColumn1Name=Value1>,PKColumn2Name=Value2>,......" public static string PKStringBuilder(DataTable primaryKeysTable, DataRow valuesDataRow) { string temp = String.Empty; foreach (DataRow kColumn in primaryKeysTable.Rows)//for all Primary Keys of the Table that is being changed { temp = String.Concat(temp, String.Concat("<", kColumn[0].ToString(), "=", valuesDataRow[kColumn[0].ToString)].ToString(), ">,")); } return temp; } }
The trick was getting the Table Name and the Primary Key Columns. I hope this code is found useful.
I want to be able to create a trigger that updates table 2 when a row is inserted into table 1. However I€™m not sure how to increment the ID in table 2 or to update only the row that has been inserted.
I want to be able to create a trigger so that when a row is inserted into table A by a specific user then the ID will appear in table B. Is it possible to find out the login id of the user inserting a row?
I believe the trigger should look something like this:
create trigger test_trigger on a for insert as insert into b(ID)
When a row gets modified and it invokes a trigger, we would like to beable to update the row that was modified inside the trigger. This is(basically) how we are doing it now:CREATE TRIGGER trTBL ON TBLFOR UPDATE, INSERT, DELETEasupdate TBLset fld = 'value'from inserted, TBLwhere inserted.id= TBL.id....This work fine but it seems like it could be optimized. Clearly we arehaving to scan the entire table again to update the row. But shouldn'tthe trigger already know which row invoked it. Do we have to scan thetable again for this row or is their some syntax that allows us toupdate the row that invoked the trigger. If not, why. It seems likethis would be a fairly common task. Thanks.
Salve, non riesco a disabilitare un trigger su sqlserver nè da queryanalyzer, nè da enterprise manager.In pratica tal cosa riuscivo a farla in Oracle con TOAD, mentre qui nonriesco.Mi interessa disattivarlo senza cancellarlo per poi riattivarlo al bisognosenza rilanciare lo script di creazione.Grazie a tuttiHi I need to disable a DB trigger and I'm not able to do this neither withquery analyzer, neither with enterprise manager.I remeber this job was quite simple using TOAd in Oracle.I'm interested in making it disabled not delete it, without run creationscript.Thanks a lot to everybody.
Hi, I am not sure if this is the right forum to post this question. I run an update statement like "Update mytable set status='S' " on the SQL 2005 management Studio. When I run "select * from mytable" for a few seconds all status = "S". After a few seconds all status turn to "H". This is a behaviour when you have an update trigger for the table. But I don't see any triggers under this table. What else would cause the database automatically change my update? Could there be any other place I should look for an update trigger on this table? Thanks,
Hi all in .net I've created an application that allows creation of triggers, i also want to allow the deletion of triggers. The trigger name is kept in a table, and apon deleting the record i want to use the field name to delete the trigger
I have the following Trigger
the error is at
DROP TRIGGER @DeleteTrigger
I'm guessing it dosen't like the trigger name being a variable instead of a static name how do i get around this?
I have a trigger set on TABLE1 so that any update to this column should set off trigger to write to the AUDIT log table, it works fine otherwise but not the very first time when table1 has null in the column. if i comment out
and i.req_fname <> d.req_fname from the where clause then it works fine the first time too. Seems like null value of the column is messing things up
Any thoughts?
Here is my t-sql
Insert into dbo.AUDIT (audit_req, audit_new_value, audit_field, audit_user)
select i.req_guid, i.req_fname, 'req_fname', IsNull(i.req_last_update_user,@default_user) as username from inserted i, deleted d
I have trigger, but not execute somedata because insert few row in every second. I use java to insert data to SQL server 2005. Data inserted to a table but not executing trigger for some data. For example 100 data every second inserted to a table.
If insert data one by one to a table trigger fires success. Please Help me.
There are two different Stored Procedures insert data into a table, is it possible to catch what stored procedure name was that trigged the trigger in the trigger?
Hi, I am trying to script a trigger on a table to accomplish the following... If a row is updated then the value in the 'date' column in that specific row would update to getDate(). I have never created a trigger before and finding it very difficult. Thank you very much in advance. Kind Regards, Sean.
Hello I am having difficulty try to get a trigger to work. I need to create a trigger querie that will insert a row from TableMain (Column LNames) table to TableA (Column LNames) Below is my querie
CREATE TRIGGER [trig_addTable_A]ON Table_A FOR INSERT ASINSERT LName (LName) SELECT LNameFROM TableMain inserted I have inserted test names into the main table but nothing in table A has inserted. What have I done wrong. Thanks
I am looking for a INSERT trigger example, to achieve the following objective: I would like the trigger to be fired when a row gets inserted into a table. I want to retrive some value from the inserted row and use this value to insert a new row in table 2. Thanks
is it possible to run a trigger forever... whose work is to archive data from a table. or how can i do the operation to archive automatically ?Regards,Kamrul Hassan
Hi, Does anybody know how could I define a for each row trigger in sql Server 2005? What I need to do is before inserting in the table look through the rows to check wheter that value overlaps with the others. "Overlap" means that this value cannot be betweent the values fo two different columns, that is why I need to go through all the table. In case that was not possible, I propose the following, load the table in a dataset and check the constraint with a for loop despite of the performance could be decreased. Any suggestion?.
Hi everybody I work on a Project that has Inbox . I need that if a record has inserted in inbox system alert to user that view it's inbox . The suitable solution for it seems trigger ,but i don't how trigger could communicate with Application. Thanks for any guides. Best Regard A.Doroudian
hi .... I am going to use trigger first time. my secnerio is that I want a common column in five tables on the insertion of a row in a particular table.. question is simple ..... can I do that???????????????????? thanks in advance.
Currently I have 3 tables; Persons, Student and Teacher. Persons is the parent table of Student and Teacher and they are linked by the Person_Id attribute. For example, if Person_Id 1 exist in Student table, it cannot be inserted anymore into Teacher table. How do I write a trigger in MS SQL to implement this business rule? Any experts can shed some light? Thanks!
I am trying to write a trigger that alows me to re-arrange the order of items. For instance, if I insert a record with a SF_NEWS_Order of "1" then all records with an order of "1" or more would increase by 1. This allows me to insert a record in the list of priorities. For some reason, the trigger is not working. If I have reords with SF_NEWS_Order values as follows:
1 2 3
I end up with this:
1 1 2 3
Can someone help with this? The code of the existing trigger is below:
CREATE TRIGGER NEWS_PRIORITY ON [dbo].[TBL_SF_NEWS] FOR INSERT, UPDATE AS Declare @Order_Code int Declare @New_ID int Declare @Exist_Record int
Set @New_ID = ( Select SF_NEWS_ID from Inserted ) Set @Order_Code = ( Select SF_NEWS_Order from Inserted ) Set @Exist_Record = ( Select SF_NEWS_ID from [dbo].[TBL_SF_NEWS] Where SF_NEWS_Order = @Order_Code and SF_NEWS_ID <> @New_ID )
If (@Exist_Record <> Null ) Begin Update [dbo].[TBL_SF_News] Set SF_NEWS_Order = (@Order_Code + 1) Where SF_NEWS_ID = @Exist_Record End
I have trigger firing during an update event. How can i fix the loop so this error will disappear..
Server: Msg 512, Level 16, State 1, Procedure TrigAssignImpTaskNew, Line 18 Subquery returned more than 1 value. This is not permitted when the subquery follows =, !=, <, <= , >, >= or when the subquery is used as an expression. The statement has been terminated.
SET QUOTED_IDENTIFIER OFF GO SET ANSI_NULLS OFF GO
ALTER procedure TrigAssignImpTaskNew @REIDint, @RRID varchar(20)
select @intCounter = count(*) from RequestRecords where REID = @REID select @intAPID = (select APID from RequestRecords where reid = @REID and ITID = null and RRSTatus = 'PE') select @intIMID = (select IMID from Applications_ImplementationGroup where apid = @intAPID)
while @intCounter <> 0 begin insert into ImplementationTasks ( IMID, ITStatus, ITStatusDate ) VALUES ( @intIMID, '0', GetDate() ) SET @RetVal = @@IDENTITY
end
Update RequestRecords set ITID = @RetVal, RRStatus = 'PR' where RRID = @RRID GO SET QUOTED_IDENTIFIER OFF GO SET ANSI_NULLS ON GO
Anyone knows how to make a good trigger to create a row id on a table every time a new row is inserted? This is to maintain row id sequence by not setting the row id field as an auto identity which may be in broken sequence after a while. Thanks.
I've looked all over the internet for articles on Triggers, but none of them do exactly what I need. Could someone please see if this trigger would work? CREATE TRIGGER DuplicateEmployeeTrigger ON Employees BEFORE INSERT AS IF EXISTS (SELECT * FROM Employees e, INSERTED i WHERE e.Forename = i.Forename AND e.Surname = i.Surname) ROLLBACK TRANSACTION GO
